Modify the grouping example to fit the output#334
Merged
dbieber merged 2 commits intogoogle:masterfrom Dec 9, 2022
Merged
Conversation
dbieber
approved these changes
Jun 7, 2021
Collaborator
|
Merging. The advantage of this over what we did in #387 is this conveys consistently that the result is printed and returning data is a reliable way to simultaneously build a python library and a CLI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I make a change according to #333.
Tested it and everything is correct.
@dbieber could you please review it?
Thank you.